build(deps): bump the all-cargo-deps group with 4 updates#2
build(deps): bump the all-cargo-deps group with 4 updates#2dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps the all-cargo-deps group with 4 updates: [cc](https://github.com/rust-lang/cc-rs), [bindgen](https://github.com/rust-lang/rust-bindgen), [libc](https://github.com/rust-lang/libc) and [criterion](https://github.com/criterion-rs/criterion.rs). Updates `cc` from 1.2.58 to 1.2.60 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/cc-rs@cc-v1.2.58...cc-v1.2.60) Updates `bindgen` from 0.71.1 to 0.72.1 - [Release notes](https://github.com/rust-lang/rust-bindgen/releases) - [Changelog](https://github.com/rust-lang/rust-bindgen/blob/v0.72.1/CHANGELOG.md) - [Commits](rust-lang/rust-bindgen@v0.71.1...v0.72.1) Updates `libc` from 0.2.183 to 0.2.184 - [Release notes](https://github.com/rust-lang/libc/releases) - [Changelog](https://github.com/rust-lang/libc/blob/0.2.184/CHANGELOG.md) - [Commits](rust-lang/libc@0.2.183...0.2.184) Updates `criterion` from 0.5.1 to 0.8.2 - [Release notes](https://github.com/criterion-rs/criterion.rs/releases) - [Changelog](https://github.com/criterion-rs/criterion.rs/blob/master/CHANGELOG.md) - [Commits](criterion-rs/criterion.rs@0.5.1...criterion-v0.8.2) --- updated-dependencies: - dependency-name: cc dependency-version: 1.2.60 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-cargo-deps - dependency-name: bindgen dependency-version: 0.72.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-cargo-deps - dependency-name: libc dependency-version: 0.2.184 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-cargo-deps - dependency-name: criterion dependency-version: 0.8.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-cargo-deps ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
📝 WalkthroughWalkthroughDependency version updates across two Cargo.toml files: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@primer3/Cargo.toml`:
- Line 27: Update the workspace MSRV in the root Cargo.toml from "1.85.0" to
"1.86.0" so it meets criterion 0.8's minimum Rust requirement; locate the
workspace-level rust-version field in the root Cargo.toml and change its value
to "1.86.0" to resolve the incompatibility introduced by adding criterion = {
version = "0.8", features = ["html_reports"] } in primer3/Cargo.toml.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3b85a2d0-d676-4ae4-895d-98709e9b3d4b
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
primer3-sys/Cargo.tomlprimer3/Cargo.toml
|
|
||
| [dev-dependencies] | ||
| criterion = { version = "0.5", features = ["html_reports"] } | ||
| criterion = { version = "0.8", features = ["html_reports"] } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify criterion 0.8 compatibility with benchmarks
# Check if html_reports feature exists in criterion 0.8
echo "=== Checking criterion 0.8 features ==="
cargo metadata --format-version 1 | \
jq -r '.packages[] | select(.name == "criterion") | .features | keys[]' | \
grep -E 'html_reports|plotting' || echo "Features not found - may need web search"
# Attempt to build the benchmarks
echo -e "\n=== Building benchmarks with criterion 0.8 ==="
cd primer3 && cargo bench --no-run 2>&1 | tee bench_build.log
# Check for build errors or warnings
if [ ${PIPESTATUS[0]} -ne 0 ]; then
echo "Benchmark build failed"
exit 1
fi
grep -i "warning\|error" bench_build.log | grep -v "^Binary" || echo "Build successful"Repository: fg-labs/primer3-rs
Length of output: 874
🌐 Web query:
Does criterion 0.8 support the html_reports feature?
💡 Result:
Yes, Criterion 0.8 supports the html_reports feature. It is listed as an available feature flag in the official documentation for version 0.8.2, which can be enabled in Cargo.toml like criterion = { version = "0.8", features = ["html_reports"] }. The feature has been present since at least version 0.3 and continues to be supported in the 0.8 series, including in the "stable" feature set.
Citations:
- 1: https://docs.rs/crate/criterion/latest/features
- 2: https://github.com/criterion-rs/criterion.rs/blob/master/CHANGELOG.md
- 3: https://crates.io/crates/criterion/0.8.1
- 4: https://docs.rs/crate/criterion/latest/source/README.md
- 5: https://docs.rs/crate/criterion/latest
🏁 Script executed:
#!/bin/bash
# Check for MSRV settings in the project
echo "=== Checking project MSRV settings ==="
if grep -r "rust-version" primer3/Cargo.toml; then
echo "MSRV found in Cargo.toml"
else
echo "No explicit MSRV in Cargo.toml"
fi
# Check benchmark code for any obvious API compatibility issues
echo -e "\n=== Inspecting benchmark code ==="
find . -name "benches" -type d -exec ls -la {} \;
find . -path "*/benches/*.rs" -type f | head -5Repository: fg-labs/primer3-rs
Length of output: 396
🌐 Web query:
What is the minimum Rust version (MSRV) required for criterion 0.8?
💡 Result:
The minimum Rust version (MSRV) required for criterion 0.8 is Rust 1.86.
Citations:
- 1: https://crates.io/crates/criterion/0.8.0
- 2: https://crates.io/crates/criterion
- 3: https://github.com/criterion-rs/criterion.rs/blob/master/CHANGELOG.md
- 4: (cargo)(deps): Update criterion requirement from 0.6.0 to 0.8.1 chrissimpkins/vectora#101
- 5: https://github.com/criterion-rs/criterion.rs
🌐 Web query:
What breaking changes were introduced in criterion 0.8 from 0.5?
💡 Result:
The primary breaking change introduced in criterion 0.8 (specifically 0.8.0) from 0.5 is the removal of async-std support. Other changes between versions include MSRV bumps (Minimum Supported Rust Version) from 1.64 in 0.5 to 1.86 in 0.8, dependency updates (e.g., clap to v4 in 0.5, real_blackbox feature changes in 0.6), and the real_blackbox feature becoming no-op in 0.6 with recommendation to use std::hint::black_box. No other explicit breaking changes are listed in the changelogs for 0.6.0, 0.7.0, or 0.8.0 beyond these.
Citations:
- 1: https://github.com/criterion-rs/criterion.rs/blob/master/CHANGELOG.md
- 2: https://github.com/criterion-rs/criterion.rs
- 3: https://crates.io/crates/criterion/0.6.0
- 4: chore(deps): update criterion requirement from 0.5.1 to 0.8.1 barter-rs/barter-rs#241
🏁 Script executed:
#!/bin/bash
# Find and read workspace Cargo.toml
echo "=== Looking for workspace Cargo.toml ==="
find . -maxdepth 2 -name "Cargo.toml" -type f | head -10
echo -e "\n=== Reading workspace Cargo.toml ==="
cat Cargo.toml 2>/dev/null | grep -A 5 "rust-version\|workspace"
echo -e "\n=== Reading benchmark code ==="
cat -n ./primer3/benches/benchmarks.rsRepository: fg-labs/primer3-rs
Length of output: 3654
Update the workspace MSRV from 1.85.0 to 1.86.0 to match criterion 0.8's requirement.
The project's workspace MSRV is set to 1.85.0, but criterion 0.8 requires a minimum of Rust 1.86. This creates an incompatibility—users on Rust 1.85.0 cannot build the project after this update. Bump the workspace rust-version in the root Cargo.toml to 1.86.0.
The html_reports feature is available in criterion 0.8 and the benchmark code uses compatible APIs.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@primer3/Cargo.toml` at line 27, Update the workspace MSRV in the root
Cargo.toml from "1.85.0" to "1.86.0" so it meets criterion 0.8's minimum Rust
requirement; locate the workspace-level rust-version field in the root
Cargo.toml and change its value to "1.86.0" to resolve the incompatibility
introduced by adding criterion = { version = "0.8", features = ["html_reports"]
} in primer3/Cargo.toml.
Bumps the all-cargo-deps group with 4 updates: cc, bindgen, libc and criterion.
Updates
ccfrom 1.2.58 to 1.2.60Release notes
Sourced from cc's releases.
Changelog
Sourced from cc's changelog.
Commits
7cad9f5chore(cc): release v1.2.60 (#1701)c15c3ebfix(ar): suppress warnings fromDmodifier probe (#1700)f4c5ac7chore(cc): release v1.2.59 (#1699)9cfcecbRegenerate target info (#1698)025d046fix(ar): deterministic archives withDmodifier (#1697)fe32d68Fix target abi parsing dor sanitiser targets (#1695)Updates
bindgenfrom 0.71.1 to 0.72.1Release notes
Sourced from bindgen's releases.
Changelog
Sourced from bindgen's changelog.
Commits
d874de8chore: Release173a6e6Update changelog.2e06749clang: Push the fix for #3277 into Type::declaration.58a8710Get the type's definition in CompInfo::from_tyd0e7d6bchore: Releasee7f0b9dUpdate changelog.2882af2Refactor item_name method to use ItemInfo structe2940cdchore: Fix some warnings with latest stable.5d7f684codegen: Avoid crashing on variadic unions without layout information.2613129Remove unused which-rustfmt featureUpdates
libcfrom 0.2.183 to 0.2.184Release notes
Sourced from libc's releases.
Changelog
Sourced from libc's changelog.
Commits
b1fd610chore: Release libc 0.2.184f596819ci: Don't enforce cargo-semver-checks4645f60linux: update ptrace_syscall_info struct14cbbectypes: RemovePadding::uninitb5dcda8pthread: UsePadding::new(\<zeroed>)rather thanPadding::uninit()bbb1c5dtypes: Add anewfunction toPaddingdf06e43Fix locale values and add RTLD_NOLOAD, some TCP constants078f5c6newlib/espidf: Move DT_* to espidf/mod.rsd32b83dAdd IP_MINTTL to bsd939e0ecDefine max_align_t for riscv64-linuxUpdates
criterionfrom 0.5.1 to 0.8.2Release notes
Sourced from criterion's releases.
... (truncated)
Changelog
Sourced from criterion's changelog.
... (truncated)
Commits
7f0d745chore: release v0.8.24a467cechore(deps): bump crate-ci/typos from 1.40.0 to 1.43.0b277a75Fix panic with uniform iteration durations in benchmarks828af14fix: don't build alloca on unsupported targetsb01316bUpdate Readme4c02a3bExclude development scripts from published packagee4e06dfchore: release v0.8.1aa548b9fix: Homepage link950c3b7fix: Typo7e3e50cchore(deps): bump crate-ci/typos from 1.23.5 to 1.40.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsSummary by CodeRabbit